Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow manually setting done dates through task modal [when the 'add done date' setting is disabled] #2860

Open
4 tasks done
n-konig opened this issue May 29, 2024 · 2 comments
Labels
scope: edit task The Create or edit task modal/dialog type: enhancement New feature or request

Comments

@n-konig
Copy link

n-konig commented May 29, 2024

⚠️ Please check that this feature request hasn't been suggested before.

  • I searched previous Ideas in Discussions didn't find any similar feature requests.
  • I searched previous Issues didn't find any similar feature requests.
  • I am only requesting a single feature. Multiple changes should be split into individual requests, with links between them.
  • I believe my requested feature will be generally applicable to other users, not just me: it is not uniquely tied to my personal workflow.

🔖 Feature description

Currently, if the option "Set done date on every completed task" is disabled, manually setting a done date in the task modal is not saved to the task.

Not all tasks need a completion date. But some do.

The feature requested is to allow the modal to save values to the Task regardless of the setting to automatically add these or not.

✔️ Solution

With option to "Set done date on every completed task" disable, the following should be allowed:

Taking the following steps:

  1. Open task modal
  2. Set status to "done"
  3. Set a done date

Should set the status to "done" and writ the done date to the task.

❓ Alternatives

No response

📝 Additional Context

No response

@n-konig n-konig added the type: enhancement New feature or request label May 29, 2024
@claremacrae
Copy link
Collaborator

This arose out of #2859.

@claremacrae claremacrae added the scope: edit task The Create or edit task modal/dialog label May 29, 2024
@claremacrae claremacrae changed the title Allow manually setting done dates through task modal Allow manually setting done dates through task modal [when the 'add done date' setting is disabled] May 29, 2024
@claremacrae
Copy link
Collaborator

Currently, if the option "Set done date on every completed task" is disabled, manually setting a done date in the task modal is not saved to the task.

This is actually not 100% true.

It turns out that when "Set done date on every completed task" is disabled:

  • If the Task is DONE when it is opened in the modal, then a manually added Done date is saved.
  • It is only when the Task is changed to DONE whilst the modal is open that a manually added Done date is not saved.

This is why I was asking for more complete reproduction steps in #2859.

So the above information provides a workaround for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: edit task The Create or edit task modal/dialog type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants