absolute DuckDB FileAttachment URL #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
reviewed
Nov 26, 2023
mbostock
reviewed
Nov 26, 2023
src/duckdb.js
Outdated
| @@ -208,7 +208,7 @@ async function insertFile(database, name, file, options) { | |||
| } | |||
| if (/\.parquet$/i.test(file.name)) { | |||
| return await connection.query( | |||
| `CREATE VIEW '${name}' AS SELECT * FROM parquet_scan('${file.name}')` | |||
| `CREATE VIEW '${name}' AS FROM parquet_scan('${file.name}')` | |||
There was a problem hiding this comment.
Is the shorter form recommended? Seems like the docs still use SELECT *.
There was a problem hiding this comment.
It's brand new. Documented in https://duckdb.org/docs/sql/query_syntax/from with one sentence “DuckDB also has an optional FROM-first syntax which enables you to also query without a SELECT statement.” The announcement (August 2023) mentions that SELECT * is "obsolete".
There was a problem hiding this comment.
I'll revert that commit for now, since I'm not sure when the new syntax was introduced and it's not related to the FileAttachment issue.
mbostock
approved these changes
Nov 26, 2023
Co-authored-by: Mike Bostock <[email protected]>
This reverts commit 9d88421.
|
I feel compelled to click on the ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've only tested this locally (not sure how unit tests could work).