Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tip: {…} can contain PointerOptions #2244

Closed
wants to merge 1 commit into from
Closed

tip: {…} can contain PointerOptions #2244

wants to merge 1 commit into from

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Nov 21, 2024

closes #2134

@Fil Fil requested a review from mbostock November 21, 2024 20:41
@mbostock
Copy link
Member

Oops, already fixed this in #2132 28bdcaf. We don’t want to add this to the TipOptions (i.e., the options to the tip mark, since the tip mark doesn’t necessitate the use of the pointer transform); we instead want to allow it in the tip mark option.

@mbostock mbostock closed this Nov 21, 2024
@Fil Fil deleted the fil/maxRadius-type branch November 22, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbostock mbostock Awaiting requested review from mbostock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Erroneous type definition for the tip {maxRadius} option
2 participants
@Fil @mbostock