Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document multi-line tick format; improve format for custom ticks #1728

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Jun 27, 2023

(ref: #1718, #1725)

@Fil Fil requested a review from mbostock June 27, 2023 09:45

:::plot https://observablehq.com/@observablehq/plot-datawrapper-style-date-axis
```js
Plot.plot({
x: {tickSpacing: 60},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example is a little less compelling having to customize the tick settings. (Presumably, ticks: 30 or ticks: d3.utcMonth.every(3) would produce equivalent output?) Maybe that’s fine, but maybe there’s a dataset with a smaller domain that would produce multi-line ticks by default, resulting in a simpler example?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could do
Plot.line(sftemp, Plot.windowY(7, {x: "date", y: "high"})).plot({y: {nice: true}})

docs/marks/axis.md Outdated Show resolved Hide resolved
Co-authored-by: Mike Bostock <[email protected]>
@mbostock mbostock force-pushed the fil/document-multi-line-ticks branch 2 times, most recently from 4745788 to 167a0dc Compare June 27, 2023 16:49
@mbostock mbostock force-pushed the fil/document-multi-line-ticks branch from 167a0dc to e039fe1 Compare June 27, 2023 16:52
@mbostock mbostock changed the title document multi-line tick format document multi-line tick format; improve format for custom ticks Jun 27, 2023
@mbostock mbostock merged commit 01baebe into main Jun 27, 2023
1 check passed
@mbostock mbostock deleted the fil/document-multi-line-ticks branch June 27, 2023 16:56
Fil added a commit that referenced this pull request Aug 21, 2023
* document multi-line tick format

(ref: #1718, #1725)

* Update docs/marks/axis.md

Co-authored-by: Mike Bostock <[email protected]>

* better formats for explicit intervals

---------

Co-authored-by: Mike Bostock <[email protected]>
chaichontat pushed a commit to chaichontat/plot that referenced this pull request Jan 14, 2024
…ervablehq#1728)

* document multi-line tick format

(ref: observablehq#1718, observablehq#1725)

* Update docs/marks/axis.md

Co-authored-by: Mike Bostock <[email protected]>

* better formats for explicit intervals

---------

Co-authored-by: Mike Bostock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants