fix waffle stroke (when constant) (#2204)

Co-authored-by: Mike Bostock <[email protected]>
observablehq · Nov 21, 2024 · 5fb8616 · 5fb8616
1 parent eb85419
commit 5fb8616
Show file tree

Hide file tree

Showing 9 changed files with 757 additions and 51 deletions.
diff --git a/src/marks/waffle.js b/src/marks/waffle.js
@@ -142,7 +142,7 @@ function waffleRender({render, ...options}) {
             .attr("transform", template`translate(${x0},${y0})`)
             .attr("d", (i) => `M${polygon[i].join("L")}Z`)
             .attr("fill", (i) => `url(#${patternId}-${i})`)
-            .attr("stroke", this.stroke == null ? null : (i) => `url(#${patternId}-${i})`)
+            .attr("stroke", this.stroke == null ? null : "none")
             .call(applyChannelStyles, this, {ariaLabel, href, title})
         )
         .node();

diff --git a/test/output/waffleShapes.svg b/test/output/waffleShapes.svg
diff --git a/test/output/waffleStroke.svg b/test/output/waffleStroke.svg
diff --git a/test/output/waffleStrokeMixed.svg b/test/output/waffleStrokeMixed.svg