Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent focus on tool dialog contents #1333

Merged
merged 2 commits into from
Jan 20, 2025
Merged

fix: prevent focus on tool dialog contents #1333

merged 2 commits into from
Jan 20, 2025

Conversation

ryanhopperlowe
Copy link
Contributor

@ryanhopperlowe ryanhopperlowe commented Jan 20, 2025 •
edited
Loading

Addresses #1129

  • ensure opening a dialog always autofocuses the close button if available
  • remove tooltips from tool icons

Signed-off-by: Ryan Hopper-Lowe [email protected]

@ryanhopperlowe ryanhopperlowe changed the title Prevent-focus-on-dialog-contents feat: prevent focus on tool dialog contents Jan 20, 2025
@ryanhopperlowe ryanhopperlowe changed the title feat: prevent focus on tool dialog contents fix: prevent focus on tool dialog contents Jan 20, 2025
@ryanhopperlowe ryanhopperlowe merged commit 28be403 into obot-platform:main Jan 20, 2025
2 checks passed
@ryanhopperlowe ryanhopperlowe deleted the prevent-focus-on-dialog-contents branch January 20, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njhale njhale njhale approved these changes

@ivyjeong13 ivyjeong13 Awaiting requested review from ivyjeong13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanhopperlowe @njhale