fix: improve object comparison in useHasChanged #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanhopperlowe
requested review from
thedadams and
ivyjeong13
and removed request for
thedadams
thedadams
approved these changes
Jan 10, 2025
ui/admin/app/hooks/useHasChanged.tsx
Outdated
Comment on lines
47
to
50
| if (aKeys.length !== bKeys.length) return false; | ||
|
|
||
| return aKeys.every( | ||
| (key) => key in b && a[key as keyof T] === b[key as keyof T] |
There was a problem hiding this comment.
nit:
Suggested change
| if (aKeys.length !== bKeys.length) return false; | |
| return aKeys.every( | |
| (key) => key in b && a[key as keyof T] === b[key as keyof T] | |
| return aKeys.length === bKeys.length && aKeys.every( | |
| (key) => key in b && a[key as keyof T] === b[key as keyof T] |
There was a problem hiding this comment.
updated this, and fixed the commit message
|
You have this marked as a |
Signed-off-by: Ryan Hopper-Lowe <[email protected]>
ryanhopperlowe
force-pushed
the
update-use-has-changed
branch
from
cec2e6c to
d9b360c
Compare
ryanhopperlowe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Hopper-Lowe [email protected]