Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor to embrace dom typographical elements #1144

Merged
merged 1 commit into from
Jan 7, 2025
Merged

chore: refactor to embrace dom typographical elements #1144

merged 1 commit into from
Jan 7, 2025

Conversation

ryanhopperlowe
Copy link
Contributor

This should create NO VISIBLE CHANGES to the UI/UX, this is purely a code refactor.

  • Removes all various TypographyX components
  • replaces them with native dom elements
  • applies default styling to said native typographical elements

Signed-off-by: Ryan Hopper-Lowe [email protected]

ivyjeong13
ivyjeong13 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@ivyjeong13 ivyjeong13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 Woo, will be nice not to have to import those anymore! Nice work!

@ryanhopperlowe ryanhopperlowe merged commit ce837ac into obot-platform:main Jan 7, 2025
2 checks passed
@ryanhopperlowe ryanhopperlowe deleted the typography-updates branch January 7, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivyjeong13 ivyjeong13 ivyjeong13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanhopperlowe @ivyjeong13