enhance: add no-reply email to server config #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a no-reply email address option to the Obot server configuration. This setting is passed down to running tools so that the sendgrid tool can send emails using a pre-configured no-reply address. Signed-off-by: Nick Hale <[email protected]>
njhale
requested review from
ibuildthecloud,
drpebcak,
StrongMonkey,
iwilltry42,
ryanhopperlowe and
g-linville
njhale
commented
Dec 31, 2024
| gatewayClient *client.Client | ||
| tokenService *jwt.TokenService | ||
| events *events.Emitter | ||
| noReplyEmailAddress string |
There was a problem hiding this comment.
should this configuration name specifically mention SendGrid; e.g. 'sendGridNoReplyAddress`?
Should it even be a full address? Maybe something like emailDomain (to match the version API) is better, and we just use a default address like obot-noreply@<emailDomain>?
(these questions apply for the environment variable names plumbed through as well)
There was a problem hiding this comment.
I don't think it should specifically mention SendGrid. It is likely this would be useful for other similar tools we might add in the future.
I do like the idea of just using an emailDomain rather than requiring them to specify the full address, but I personally think it is fine either way.
g-linville
approved these changes
Dec 31, 2024
StrongMonkey
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a no-reply email address option to the Obot server configuration. This setting is passed down to running tools so that the sendgrid tool can send emails using a pre-configured no-reply address.