fix: fix public types that have multiple ref names

Signed-off-by: Donnie Adams <[email protected]>

apiclient/types/oauthapp.go

@@ -14,7 +14,7 @@ type OAuthAppType string
 
 type OAuthApp struct {
 	OAuthAppManifest
-	OAuthAppExternalStatus
+	RefNameAssigned bool `json:"refNameAssigned,omitempty"`
 }
 
 type OAuthAppManifest struct {

apiclient/types/webhook.go

@@ -3,7 +3,7 @@ package types
 type Webhook struct {
 	Metadata
 	WebhookManifest
-	WebhookExternalStatus
+	RefNameAssigned            bool  `json:"refNameAssigned,omitempty"`
 	LastSuccessfulRunCompleted *Time `json:"lastSuccessfulRunCompleted,omitempty"`
 }
 

pkg/api/handlers/webhooks.go

@@ -108,10 +108,12 @@ func convertWebhook(webhook v1.Webhook, urlPrefix string) *types.Webhook {
 		links = []string{"invoke", fmt.Sprintf("%s/webhooks/%s", urlPrefix, webhook.Status.External.RefName)}
 	}
 
+	manifest := webhook.Spec.WebhookManifest
+	manifest.RefName = webhook.Status.External.RefName
 	wh := &types.Webhook{
 		Metadata:                   MetadataFrom(&webhook, links...),
-		WebhookManifest:            webhook.Spec.WebhookManifest,
-		WebhookExternalStatus:      webhook.Status.External,
+		WebhookManifest:            manifest,
+		RefNameAssigned:            webhook.Status.External.RefNameAssigned,
 		LastSuccessfulRunCompleted: v1.NewTime(webhook.Status.LastSuccessfulRunCompleted),
 	}
 

pkg/gateway/server/oauth_apps.go

@@ -124,8 +124,8 @@ func (s *Server) createOAuthApp(apiContext api.Context) error {
 
 // updateOAuthApp updates an existing OAuth app registration in the database (admin only).
 func (s *Server) updateOAuthApp(apiContext api.Context) error {
-	appManifest := new(types2.OAuthAppManifest)
-	if err := apiContext.Read(appManifest); err != nil {
+	var appManifest types2.OAuthAppManifest
+	if err := apiContext.Read(&appManifest); err != nil {
 		return apierrors.NewBadRequest(fmt.Sprintf("invalid OAuth app: %s", err))
 	}
 
@@ -135,13 +135,13 @@ func (s *Server) updateOAuthApp(apiContext api.Context) error {
 		return err
 	}
 
-	merged := types.MergeOAuthAppManifests(&originalApp.Spec.Manifest, appManifest)
-	if err := types.ValidateAndSetDefaultsOAuthAppManifest(merged); err != nil {
+	merged := types.MergeOAuthAppManifests(originalApp.Spec.Manifest, appManifest)
+	if err := types.ValidateAndSetDefaultsOAuthAppManifest(&merged); err != nil {
 		return apierrors.NewBadRequest(fmt.Sprintf("invalid OAuth app: %s", err))
 	}
 
 	// Update the app.
-	originalApp.Spec.Manifest = *merged
+	originalApp.Spec.Manifest = merged
 	if err := apiContext.Update(&originalApp); err != nil {
 		return err
 	}
@@ -512,9 +512,10 @@ func convertOAuthAppRegistrationToOAuthApp(app v1.OAuthApp, baseURL string) type
 		links = append(links, "refreshURL", refreshURL)
 	}
 	appManifest.Metadata = handlers.MetadataFrom(&app, links...)
+	appManifest.RefName = app.Status.External.RefName
 	return types2.OAuthApp{
-		OAuthAppManifest:       appManifest,
-		OAuthAppExternalStatus: app.Status.External,
+		OAuthAppManifest: appManifest,
+		RefNameAssigned:  app.Status.External.RefNameAssigned,
 	}
 }
 

pkg/gateway/types/oauth_apps.go

@@ -146,8 +146,8 @@ func ValidateAndSetDefaultsOAuthAppManifest(r *types.OAuthAppManifest) error {
 	return errors.Join(errs...)
 }
 
-func MergeOAuthAppManifests(r, other *types.OAuthAppManifest) *types.OAuthAppManifest {
-	retVal := *r
+func MergeOAuthAppManifests(r, other types.OAuthAppManifest) types.OAuthAppManifest {
+	retVal := r
 
 	if other.RefName != "" {
 		retVal.RefName = other.RefName
@@ -167,8 +167,11 @@ func MergeOAuthAppManifests(r, other *types.OAuthAppManifest) *types.OAuthAppMan
 	if other.TenantID != "" {
 		retVal.TenantID = other.TenantID
 	}
+	if other.Name != "" {
+		retVal.Name = other.Name
+	}
 
-	return &retVal
+	return retVal
 }
 
 // OAuthTokenResponse represents a response from the /token endpoint on an OAuth server.