-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add abnormally dilated cellular component template #892
base: master
Are you sure you want to change the base?
Conversation
This commit intends to add a new phenotype pattern template draft for community review. If applied, this commit will fix #891.
# examples: | ||
# - http://purl.obolibrary.org/obo/MP_0004089 # dilated sarcoplasmic reticulum | ||
# - http://purl.obolibrary.org/obo/MP_0011632 # dilated mitochondrion | ||
# - http://purl.obolibrary.org/obo/HP_0030774 # Mitochondrial swelling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a transient swelling phenotype or non-transient dilation?
Need conformation from HPO that this example is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here is a ZP example ZP:0012665 http://purl.obolibrary.org/obo/ZP_0012665 Golgi apparatus cholangiocyte dilated, abnormal
http://purl.obolibrary.org/obo/ZP_0101477 endoplasmic reticulum liver dilated, abnormal
ORCiD: 0000-0002-9900-7880
|
||
annotations: | ||
- annotationProperty: related_synonym | ||
text: "swollen %s" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this synonym, because it is misleading.
I do not think it is a good idea to include the time course in the PATO definitions. |
Discussed on the UPheno call 10/20 |
This commit intends to add a new phenotype pattern template draft for community review.
If applied, this commit will fix #891.