Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uPheno 2 review #40

Open
4 tasks
matentzn opened this issue Sep 18, 2022 · 5 comments
Open
4 tasks

uPheno 2 review #40

matentzn opened this issue Sep 18, 2022 · 5 comments
Assignees

Comments

@matentzn
Copy link
Contributor

matentzn commented Sep 18, 2022

2022-09-16 @rays22, @souzadevinicius, @ar-ibrahim, @matentzn

  • Why is there no 'abnormal femur' class in uPheno? - These should be automatically generated?
  • 'decreased length femur': why is 'decreased length' under 'decreased size'? see --> PATO:0000122 length
  • Try to use NLP or graph ML to predict hierarchies/facilitate categorisation and fill missing gaps?
  • Why is 'absent' is not a child of 'abnormal'?
@matentzn
Copy link
Contributor Author

@rays22 no need to act on this ticket, we will discuss it in the Friday meetings. The important thing is that you and Arwa spend 60-90 minutes each week to just look at uPheno in OLS and figure out "odditities" (classifications that look unintuitive or wrong) and "opportunities" (missing links that should be there).

@matentzn
Copy link
Contributor Author

matentzn commented Sep 23, 2022

  • rename abnormal phenotype or parts
  • right now not all intermediate classes (abnormal muscle of abdomen) are created, which seems sometimes a bit random. Maybe create if more than 1 SSPO child?

@matentzn
Copy link
Contributor Author

  • remove all logical axioms that don't conform not just EQs - FYPO classes have a lot of subclass of statements that are also broken.

@matentzn
Copy link
Contributor Author

  • make QC check to detect normal phenotypes under abnormal ones
  • make issues for all SSPOs where this violation happens

@matentzn
Copy link
Contributor Author

Consider removing all axioms other than A sub B from SSPO? Would be a shame for correct partial EQs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants