-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sensory corpuscle #3295
Add sensory corpuscle #3295
Conversation
Adds sensory corpuscle and positions Meissner, Pacinian, Ruffini and Herbst's under it.
src/ontology/uberon-edit.obo
Outdated
synonym: "COEC" EXACT [PMID:35356056] | ||
synonym: "cutaneous end-organ complex" EXACT [PMID:35356056] | ||
xref: http://www.wikidata.org/entity/Q126363978 | ||
is_a: UBERON:0005162 ! multi cell part structure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The definition of multi cell part structure
is:
A structure consisting of multiple cell components but which is not itself a cell and does not have (complete) cells as a part.
In sensory corpuscles there are some complete cells. I'm not aware if there is a term that comprises parts of cells and complete cells, but I will have a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The definition of
multi cell part structure
is:A structure consisting of multiple cell components but which is not itself a cell and does not have (complete) cells as a part.
In sensory corpuscles there are some complete cells. I'm not aware if there is a term that comprises parts of cells and complete cells, but I will have a look.
Oh, curious. I had not seen the definition, I interpreted quite the oposite from the label!!
So apparently the capsule of the Pacinian corpuscle is being excluded altogether from the Pacinian corpuscle itself.
I'll copy that in the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ruffini nerve ending seems to refer to Ruffini corpuscle. I think it should be relabeled, but in another ticket.
Once the branch is updated, I will approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
With new OWL API 4.5.29 we can now define idspaces for NIF_Subcellular. Its terms were mistakenly changed to the OBO namespace when using Protégé 5.6.5. This commit fixes that.
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so. |
@anitacaron what is missing in this PR? |
From my part, it looks good. You can go ahead and finish your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Adds sensory corpuscle and positions Meissner, Pacinian, Ruffini and Herbst's under it.
Related to #3290 .
Note: required for lamellar cell:
PS: Some other modifications happened on the file by the time of saving. Not sure how to avoid them.