Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release artefacts #307

Merged
merged 5 commits into from
Dec 8, 2023
Merged

Prepare release artefacts #307

merged 5 commits into from
Dec 8, 2023

Conversation

rays22
Copy link
Contributor

@rays22 rays22 commented Dec 7, 2023

Remove unintended equivalencies

* Errors to be fixed:
    1. OBA:2045390 [basophil ratio](http://purl.obolibrary.org/obo/OBA_2045390) appears to be equivalent to OBA:2045392 [basophil to leukocyte ratio](http://purl.obolibrary.org/obo/OBA_2045392)
    2. OBA:2045391 [eosinophil ratio](http://purl.obolibrary.org/obo/OBA_2045391) appears to be equivalent to OBA:2045393 [eosinophil to leukocyte ratio](http://purl.obolibrary.org/obo/OBA_2045393)
* resolution for release:
    1. keep these:
    - OBA:2045389 [leukocyte ratio](http://purl.obolibrary.org/obo/OBA_2045389)
        - OBA:2045390 [basophil ratio](http://purl.obolibrary.org/obo/OBA_2045390)
        - OBA:2045391 [eosinophil ratio](http://purl.obolibrary.org/obo/OBA_2045391)
    2. remove these:
        - OBA:2045393 [eosinophil to leukocyte ratio](http://purl.obolibrary.org/obo/OBA_2045393)
        - OBA:2045392 [basophil to leukocyte ratio](http://purl.obolibrary.org/obo/OBA_2045392)
* explanation:
    1. basophil is a leukocyte
    2. eosinophil is a leukocyte
        --> resulting in unintended equivalencies
@rays22 rays22 self-assigned this Dec 7, 2023
@rays22 rays22 marked this pull request as draft December 7, 2023 19:18
@rays22 rays22 changed the title Remove unintended equivalencies Prepare release artefacts Dec 7, 2023
@rays22 rays22 marked this pull request as ready for review December 7, 2023 20:24
@ar-ibrahim
Copy link
Collaborator

OBA:2045393 eosinophil to leukocyte ratio - OBA:2045392 basophil to leukocyte ratio

@rays22 Yes eosinophils and basophils are leukocytes but I think these ratios refer to total leukocyte count.

@rays22
Copy link
Contributor Author

rays22 commented Dec 8, 2023

OBA:2045393 eosinophil to leukocyte ratio - OBA:2045392 basophil to leukocyte ratio

@rays22 Yes eosinophils and basophils are leukocytes but I think these ratios refer to total leukocyte count.

The label suggests that, but the logical definitions do not express that unfortunately. The two classes cause a certain type of error (incoherence) in the ontology. For this reason, I have removed the two classes above, because they are unintended equivalent classes of other ones. The two classes could be reintroduced if we can come up with a pattern with an appropriate logical axiom.

@rays22 rays22 merged commit 2aa43b9 into master Dec 8, 2023
@rays22 rays22 deleted the release-2023-12-07 branch December 8, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants