-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new 'response to' term #299
Conversation
@@ -117,3 +117,4 @@ OBA:2050330 CHEBI:135983 teriparatide https://orcid.org/0000-0001-6757-4744 | |||
OBA:2050333 CHEBI:31941 oxaliplatin https://orcid.org/0000-0001-6757-4744 | |||
OBA:2045298 CHEBI:145810 insulin https://orcid.org/0000-0001-8314-2140 | |||
OBA:2045299 CHEBI:17234 glucose https://orcid.org/0000-0001-8314-2140 | |||
OBA:2050352 CHEBI:35526 hypoglycemic agent https://orcid.org/0000-0001-6757-4744 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to use the response_to_chemical_with_role_stimulus
pattern template, because the CHEBI:35526 hypoglycemic agent is a subclass of CHEBI:50906 role and I would think that putting it into the response_to_chemical_stimulus_trait
template should result in logical errors.
It is interesting that the QC did not catch it. How does owl:Nothing
look like when you open oba-edit.obo
in Protege?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if you use theresponse_to_chemical_with_role_stimulus
pattern, then the response to hypoglycemic agent
will be a subclass of trait in response to drug, which it is not at the moment. Using a role
entity in the response_to_chemical_stimulus_trait
used to generate logical errors. It is strange it does in this case.
…m/obophenotype/bio-attribute-ontology into add_response-to-antidiabetic_term
issue #298