Don't wrap checks with important side-effects in Q_ASSERT()

Was causing the command line parsing to fail in release configs.
oblivioncth · Jul 10, 2024 · 086051b · 086051b
1 parent cfccc27
commit 086051b
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/lib/src/fp-items.cpp b/lib/src/fp-items.cpp
@@ -113,11 +113,12 @@ GameDataParameters::GameDataParameters(const QString& rawParameters)
 
     QCommandLineParser parser;
     parser.setSingleDashWordOptionMode(QCommandLineParser::ParseAsLongOptions);
-    Q_ASSERT(parser.addOptions({
+    bool optAdd = parser.addOptions({
         OPT_EXTRACT,
         OPT_EXTRACTED,
         OPT_SERVER
-    }));
+    });
+    Q_ASSERT(optAdd);
 
     // Determine params
     QStringList param{u"GDP"_s}; // Need to add dummy "executable name" for QCommandLineParser, it's ignored