Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended phi-calculus #47

Merged
merged 15 commits into from
Sep 2, 2024
Merged

Extended phi-calculus #47

merged 15 commits into from
Sep 2, 2024

Conversation

Anatolay
Copy link
Collaborator

@Anatolay Anatolay commented Aug 29, 2024

PR-Codex overview

The focus of this PR is to refactor the term-rewriting system metatheory in the ARS.lean file.

Detailed summary

  • Added definitions for properties like Reflexive and Transitive
  • Defined ReflTransGen for reflexive transitive closure
  • Implemented DiamondProperty, Confluence, Takahashi
  • Added functions for implications between properties

The following files were skipped due to too many changes: Extended/ARS.lean, Extended/Record.lean, Extended/Reduction/Regular/Definition.lean, Extended/Reduction/Parallel/Definition.lean, Extended/Confluence/CompleteDevelopment.lean, Extended/Confluence/Equivalence.lean

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@0crat
Copy link

0crat commented Aug 29, 2024

@Anatolay It is not a good idea to name Git branches like "extended". As per our policy, this violates the naming convention and incurs a -12 point penalty. For future reference, name your branch after the ticket number you're working on, e.g., "46". This helps maintain consistency and clarity in our workflow. Your current balance stands at +33.

@Anatolay Anatolay changed the title Extended Extended phi-calculus Sep 2, 2024
@Anatolay Anatolay merged commit af86252 into master Sep 2, 2024
2 checks passed
@0crat
Copy link

0crat commented Sep 2, 2024

@Anatolay Hey there! 👋 Thanks for your contribution, but it looks like we've got some room for improvement. Your 1510 hits-of-code are impressive, but remember, quality over quantity! 😉 We had to deduct points for the high hit count and lack of code review. Only 1 comment? Let's aim for at least 6 next time to avoid deductions. Despite the setbacks, you've earned 4 points (we always ensure a minimum reward). Keep the contributions coming, but focus on smaller, reviewable chunks. Your current balance stands at -14. Let's work on boosting that score!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants