Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix termination issues #21

Merged
merged 9 commits into from
Apr 17, 2024
Merged

Fix termination issues #21

merged 9 commits into from
Apr 17, 2024

Conversation

eyihluyc
Copy link
Member

@eyihluyc eyihluyc commented Feb 6, 2024

This PR fixes all decreasing_by sorry's.

Most fixes were achieved by introducing two mutually dependent functions, one of which was built with the structural induction on Term, and another one – with induction on Bindings.

Another kind of issue was caused by consBindingsRedMany, which is defined by induction on (obj l1) ⇝* (obj l2). For some reason, structural recursion was not applied directly because (obj l1) and (obj l2) do not happen to be variables. This thread on Zulip was about a similar issue and helped to find the solution. However it was still not enough because "code generator does not support recursor 'ReflTransGen.rec' yet, consider using 'match ... with' and/or structural recursion". Structural recursion could not be used because of non-variable arguments, so now we rely on Mathlib.Util.CompileInductive to generate ReflTransGen.rec.

Also, this PR updates lean-toolchain and contains code refactoring which was caused by the update.


PR-Codex overview

The focus of this PR is to introduce new dependencies and update existing ones.

Detailed summary

  • Added new dependencies quote4, aesop, proofwidgets, and importGraph
  • Updated dependencies std, doc-gen4, and mathlib4
  • Modified functions incLocatorsFrom, substitute, substituteLst, subst_inc_cancel, subst_inc_cancel_Lst, lookup, and insert_φ

The following files were skipped due to too many changes: Minimal/Calculus.lean

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@eyihluyc eyihluyc marked this pull request as ready for review March 24, 2024 13:57
@fizruk fizruk merged commit a80f365 into master Apr 17, 2024
2 checks passed
@fizruk fizruk deleted the termination branch April 17, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants