Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #16
This is an attempt to clean up the code. So far, the following was done:
InsertAll
andInsertMany
,AttrList
toBindings
,Reduce
namespace and closedPReduce
namespace.We further need to add explanations to the documentation, and maybe we want to split the formalization into separate more focused files.
PR-Codex overview
This PR focuses on refactoring the code by replacing
AttrList
withBindings
and making related changes.Detailed summary
AttrList
withBindings
throughout the codebase.Bindings
instead ofAttrList
.mapBindings
function to work withBindings
instead ofAttrList
.mapBindings_compose
function to compose multiplemapBindings
calls.min_free_loc
function to calculate the minimal free locator in a term.min_free_loc_inc
function to increment the minimal free locator in a term.subst_inc_cancel
function to cancel the effect ofsubstitute
andincLocatorsFrom
on free locators.lookup
function to work withBindings
instead ofAttrList
.