feat(#346): remove redundant if statements #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rultor merge |
@volodya-lombrozo The pull request is closed already, so I can't merge it |
@volodya-lombrozo I'm sorry, I don't understand you :( Check this page and try again please |
|
@volodya-lombrozo Thanks for your contribution! You've earned +4 points: +4 base, -16 for no code review, -4 for insufficient comments (1), -8 for low hits-of-code (14), +28 adjustment. Remember, code reviews and more substantial contributions (>20 hits-of-code) can significantly boost your points. Keep improving! Your balance: +176. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I remove an outdated puzzle and redundant if statements.
Closes: #346
PR-Codex overview
The focus of this PR is to remove an ad-hoc solution for storing array elements in
StoreArray.Detailed summary
res.addAll(this.array.opcodes())for all cases.