-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#376): Towards Agent Base Acrhitecture #379
Conversation
@yegor256 Could you take a look, please? There are lot's of changes, but they are rather similar. |
@yegor256 friendly reminder |
@volodya-lombrozo looks good! However, it's rather hard to understand what exactly happens when those agents meet certain instructions. If you can create a set of tests (maybe in YAML files), where I can see something like this: opcodes:
- ILOAD 423
- ILOAD 7
- IADD
agents:
- AdditionAgent
- SomeOtherAgent
eo:
432.add 7 Maybe you can merge this PR and then create such tests in additional PRs. They will help us understand how agents work, by illustrative examples. Also, in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@volodya-lombrozo looks good, but integration tests are very much needed
@yegor256 Thank you for the review! I will try to implement this tests as soon as possible. |
@rultor merge |
@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here |
@volodya-lombrozo Done! FYI, the full log is here (took me 8min) |
@volodya-lombrozo Thanks for your contribution! You've earned +5 points: +20 base, +30 for hits-of-code (capped at 30 for 2155 HOC), -7 for exceeding 200 HOC, -15 for exceeding 800 HOC, -15 for no code review, -10 for no reviewer comments. While the large code size impacted your score, we appreciate your effort. Keep the contributions coming, but consider smaller, more focused changes. Your running balance is +196. |
In this PR I has made an attempt to change an acritecture from "Handlers" to "Agents".
Agents are independent and try do decompile only those instructions, they understand.
This changes might make the architecture a bit less coupled.
Closes: #376.
History:
PR-Codex overview
This PR adds a new
DecompilationAgent
interface and updates various classes to implement it. It also changes the package name and imports for consistency.Detailed summary
DecompilationAgent
interfaceDecompilationAgent
handlers
toagents