Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#344): Enable 'spring-fat' Integration Test #365

Merged
merged 6 commits into from
Aug 6, 2024

Conversation

volodya-lombrozo
Copy link
Member

@volodya-lombrozo volodya-lombrozo commented Aug 6, 2024

In this PR I finally enabled 'spring-fat' integration test and not it works without any problems.
Closes: #344.
History:


PR-Codex overview

This PR focuses on improving type inference in method invocations.

Detailed summary

  • Updated type inference in InterfaceInvocation for method invocations.
  • Added vtype field to Constant class for constant value type.
  • Modified LocalVariable and Return classes to handle type comparisons.
  • Updated test cases in JeoAndOpeoTest for method instructions.
  • Added a new XMIR file for DateFormatterRegistrar$LongToDateConverter.

The following files were skipped due to too many changes: src/test/resources/xmir/disassembled/DateFormatterRegistrar$LongToDateConverter.xmir, src/test/resources/xmir/disassembled/CachingJupiterConfiguration2.xmir, src/test/resources/xmir/disassembled/EngineDiscoveryRequestResolver$DefaultInitializationContext.xmir

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@volodya-lombrozo
Copy link
Member Author

@rultor merge

@rultor
Copy link
Contributor

rultor commented Aug 6, 2024

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 1147744 into objectionary:master Aug 6, 2024
11 checks passed
@rultor
Copy link
Contributor

rultor commented Aug 6, 2024

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 7min)

@0crat
Copy link

0crat commented Aug 6, 2024

@volodya-lombrozo Hey there! 👋 Nice work on your contribution! You've scored +5 points, which breaks down like this: +25 base, -7 for the 686 hits-of-code (it's over 200), -15 for no code review, and -5 for only 2 comments. We added +7 to keep you motivated. Remember, more reviews and comments can boost your score next time! Keep the contributions flowing - your total is now +276. Looking forward to your next commit! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constructor.java:42-45: Continue enable 'spring-fat'...
4 participants