Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#344): Fix Several Problems With Constructors Transformation #362

Merged
merged 6 commits into from
Aug 2, 2024

Conversation

volodya-lombrozo
Copy link
Member

@volodya-lombrozo volodya-lombrozo commented Aug 2, 2024

In this PR I fix several bugs related to Constructors and Super calls transformations.
To identify the problems I added several test cases.

Related to #344.
History:


PR-Codex overview

This PR enhances variable naming consistency, refactors type checking logic, and updates XML attributes.

Detailed summary

  • Updated variable prefix from local to local-
  • Refactored type checking logic for Labeled nodes
  • Updated XML attributes from local1 to local-1

The following files were skipped due to too many changes: src/test/resources/xmir/disassembled/SpringBootExceptionHandler$LoggedExceptionHandlerThreadLocal.xmir, src/test/resources/xmir/disassembled/OAuth2ClientRegistrationRepositoryConfiguration.xmir, src/test/resources/xmir/disassembled/DefaultRouterFunctionSpec.xmir

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@volodya-lombrozo
Copy link
Member Author

@rultor merge

@rultor
Copy link
Contributor

rultor commented Aug 2, 2024

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit cc85561 into objectionary:master Aug 2, 2024
11 checks passed
@rultor
Copy link
Contributor

rultor commented Aug 2, 2024

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 8min)

@0crat
Copy link

0crat commented Aug 2, 2024

@volodya-lombrozo 🎉 Awesome job on your contribution! You've snagged +5 points this time. While we had to adjust for a few things (like code size and review), your effort is totally appreciated! 💪 Keep the great work coming, and you'll be racking up points in no time. Your current score is a cool +306. Let's keep this momentum going!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants