Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#329): Print Java Streams as PHI Expressions #340

Merged
merged 21 commits into from
Jul 11, 2024

Conversation

volodya-lombrozo
Copy link
Member

@volodya-lombrozo volodya-lombrozo commented Jul 9, 2024

In this PR I added the special integration test that checks how opeo-maven-plugin converts Java Streams to PHI expressions.
It is only the first attempt to convert them, so the representation might (and will) dramatically changed in the future.

Related to #329.


PR-Codex overview

This PR updates class names and refactors code for clarity.

Detailed summary

  • Renamed MulTest to MultiplicationTest
  • Updated Mul class to Multiplication
  • Added Typed interface to Empty and ArrayConstructor
  • Refactored ReturnHandler to handle different return types

The following files were skipped due to too many changes: src/it/streams/src/main/java/org/eolang/streams/Main.java, src/main/java/org/eolang/opeo/decompilation/handlers/CheckCastHandler.java, src/main/java/org/eolang/opeo/decompilation/handlers/InvokedynamicHandler.java, src/it/streams/verify.groovy, src/main/java/org/eolang/opeo/compilation/XmirParser.java, src/main/java/org/eolang/opeo/ast/LocalVariable.java, src/test/java/org/eolang/opeo/ast/CheckCastTest.java, src/main/java/org/eolang/opeo/ast/CheckCast.java, src/main/java/org/eolang/opeo/ast/Return.java, src/test/java/org/eolang/opeo/ast/ReturnTest.java, src/test/java/org/eolang/opeo/ast/DynamicInvocationTest.java, src/it/streams/pom.xml, src/main/java/org/eolang/opeo/ast/DynamicInvocation.java, src/main/java/org/eolang/opeo/ast/Handle.java, src/test/resources/xmir/disassembled/Lambda.xmir, src/test/resources/xmir/disassembled/Main.xmir

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@volodya-lombrozo volodya-lombrozo marked this pull request as ready for review July 11, 2024 13:10
@volodya-lombrozo
Copy link
Member Author

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jul 11, 2024

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 7d0623d into objectionary:master Jul 11, 2024
11 checks passed
@rultor
Copy link
Contributor

rultor commented Jul 11, 2024

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 9min)

@0crat
Copy link

0crat commented Jul 12, 2024

@volodya-lombrozo Thanks for the contribution! You've earned +60 points for this (+20 as a basis, +40 for 1844 hits-of-code). Please, keep them coming. Your running balance is +100.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants