Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#933): use -- instead of empty values #934

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

volodya-lombrozo
Copy link
Member

In this PR I change the way we store empty bytes array byte[0] into directives. Now we use the special value --.

Related to #933.

@volodya-lombrozo
Copy link
Member Author

@yegor256 Could you review these changes, please?

Copy link
Member

@yegor256 yegor256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@volodya-lombrozo
Copy link
Member Author

@rultor merge

@rultor
Copy link
Contributor

rultor commented Dec 3, 2024

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here.

@rultor rultor merged commit dc5e14d into objectionary:master Dec 3, 2024
11 checks passed
@rultor
Copy link
Contributor

rultor commented Dec 3, 2024

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 10min).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants