Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#509): Implement IINC, MULTIANEWARRAY, LOOKUPSWITCH, TABLESWITCH instructions disassembly #511

Merged

Conversation

volodya-lombrozo
Copy link
Member

@volodya-lombrozo volodya-lombrozo commented Mar 15, 2024

In this PR I implemented TABLESWITCH, LOOKUPSWITCH, IINC and MULTIANEWARRAY instructions disasembling to XMIR.
This was the last set of instructions that we needed to disassemble.

Closes: #509
History:


PR-Codex overview

The PR adds constructor to DirectivesMethod, enhances error message in DataType, and implements unimplemented ASM instructions in DirectivesMethodVisitor.

Detailed summary

  • Added constructor to DirectivesMethod
  • Enhanced error message in DataType
  • Implemented unimplemented ASM instructions in DirectivesMethodVisitor

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@volodya-lombrozo
Copy link
Member Author

@rultor merge

@rultor
Copy link
Contributor

rultor commented Mar 15, 2024

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 027b02b into objectionary:master Mar 15, 2024
8 checks passed
@rultor
Copy link
Contributor

rultor commented Mar 15, 2024

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 15min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DirectivesMethodVisitor.java:44-51: Implement the rest of...
3 participants