Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty bytes are represented incorrectly in XMIR #933

Closed
yegor256 opened this issue Dec 2, 2024 · 7 comments
Closed

empty bytes are represented incorrectly in XMIR #933

yegor256 opened this issue Dec 2, 2024 · 7 comments
Assignees
Labels
bug Something isn't working soon This issue will be solved soon

Comments

@yegor256
Copy link
Member

yegor256 commented Dec 2, 2024

I see this in XMIR:

<o base="org.eolang.string" name="signature"><!-- "" -->
  <o base="org.eolang.bytes"/>
</o>

This is not a valid way to represent empty bytes. Instead, we should do this:

<o base="org.eolang.string" name="signature"><!-- "" -->
  <o base="org.eolang.bytes">--</o>
</o>

We'll add a lint for this soon: objectionary/lints#77

@volodya-lombrozo
Copy link
Member

@yegor256 I see, ok, will fix it.

@volodya-lombrozo volodya-lombrozo self-assigned this Dec 2, 2024
@volodya-lombrozo volodya-lombrozo added bug Something isn't working soon This issue will be solved soon labels Dec 2, 2024
@volodya-lombrozo
Copy link
Member

Here is the explanation what is what: objectionary/eo#3545 (comment)

@volodya-lombrozo
Copy link
Member

@rultor release, tag is 0.6.26, title is 0.6.26

@rultor
Copy link
Contributor

rultor commented Dec 3, 2024

@rultor release, tag is 0.6.26, title is 0.6.26

@volodya-lombrozo OK, I will release it now. Please check the progress here.

@rultor
Copy link
Contributor

rultor commented Dec 3, 2024

@rultor release, tag is 0.6.26, title is 0.6.26

@volodya-lombrozo Done! FYI, the full log is here (took me 13min).

@volodya-lombrozo
Copy link
Member

volodya-lombrozo commented Dec 3, 2024

@yegor256 Could you check the new version, please? There are no @name attributes anymore and empty bytes are represented as --

@yegor256
Copy link
Member Author

yegor256 commented Dec 3, 2024

@volodya-lombrozo thanks!

@yegor256 yegor256 closed this as completed Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working soon This issue will be solved soon
Projects
None yet
Development

No branches or pull requests

3 participants