Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MaxStack.java:38-41: Refactor the MaxStack class. The... #752

Closed
0pdd opened this issue Oct 10, 2024 · 0 comments · Fixed by #754
Closed

MaxStack.java:38-41: Refactor the MaxStack class. The... #752

0pdd opened this issue Oct 10, 2024 · 0 comments · Fixed by #754

Comments

@0pdd
Copy link

0pdd commented Oct 10, 2024

The puzzle 540-50609d1b from #540 has to be resolved:

jeo-maven-plugin/src/main/java/org/eolang/jeo/representation/bytecode/MaxStack.java

Lines 38 to 41 in 12ea088

* @todo #540:60min Refactor the MaxStack class.
* The MaxLocals class has a high cognitive complexity. Refactor the class
* to reduce the complexity. You might also extract some methods to make
* the class more readable. Don't forget to remove the @SuppressWarnings.

The puzzle was created by volodya-lombrozo on 10-Oct-24.

Estimate: 60 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Oct 10, 2024
@volodya-lombrozo
feat(#540): add one more suppression
12ea088
This was referenced Oct 10, 2024
Closed
Closed
Closed
Closed
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 11, 2024
@volodya-lombrozo
feat(objectionary#752): add DataFlow and MaxStackFlow classes as firs…
b35719e 
…t refactoring examples
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 11, 2024
@volodya-lombrozo
feat(objectionary#752): beautify MaxStackFlow class
0f46e82
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 11, 2024
@volodya-lombrozo
feat(objectionary#752): remove old implementation of MaxStack
9381127
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 11, 2024
@volodya-lombrozo
feat(objectionary#752): add draft of MaxLocalsFlow
96aadb9
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 11, 2024
@volodya-lombrozo
feat(objectionary#752): use max locals flow
f785da9
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 11, 2024
@volodya-lombrozo
feat(objectionary#752): remove the old implementation of MaxLocals
70100ae
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 11, 2024
@volodya-lombrozo
feat(objectionary#752): add more javadocs
031c947
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 11, 2024
@volodya-lombrozo
feat(objectionary#752):remove redundant code
5e7d0e4
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 11, 2024
@volodya-lombrozo
feat(objectionary#752): fix all the code offences
9de27c7
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 11, 2024
@volodya-lombrozo
feat(objectionary#752): fix unit tests
a3fee1c
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 11, 2024
@volodya-lombrozo
feat(objectionary#752): combine if statements
86b4e34
@volodya-lombrozo volodya-lombrozo mentioned this issue Oct 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#752): Refactor MaxStack and MaxLocals classes volodya-lombrozo/jeo-maven-plugin
1 participant
@0pdd