Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CustomClassWriter.java:127-134: Remove ad-hoc solution... #540

Closed
0pdd opened this issue Apr 3, 2024 · 2 comments · Fixed by #744
Closed

CustomClassWriter.java:127-134: Remove ad-hoc solution... #540

0pdd opened this issue Apr 3, 2024 · 2 comments · Fixed by #744
Labels
soon This issue will be solved soon

Comments

@0pdd
Copy link

0pdd commented Apr 3, 2024

The puzzle 528-c5cdad7d from #528 has to be resolved:

jeo-maven-plugin/src/main/java/org/eolang/jeo/representation/bytecode/CustomClassWriter.java

Lines 127 to 134 in e462828

* @todo #528:90min Remove ad-hoc solution for method frames, stack and locals computation.
* This method is a workaround for the issue with the ASM library that doesn't allow
* to compute frames and stack values per method basis. Here I use reflection to change
* the computation mode to COMPUTE_ALL_FRAMES and then restore it back to the original value.
* This is a hacky solution and should be removed once the issue is fixed in the ASM library.
* Another option is to compute all this values ourselves.
* You can read more about this issue here:
* https://stackoverflow.com/questions/78262674/how-to-mix-manual-and-automatic-calculation-of-max-locals-max-stack-and-frames

The puzzle was created by rultor on 03-Apr-24.

Estimate: 90 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Apr 3, 2024
@rultor
Merge branch '__rultor'
e462828
This was referenced Apr 3, 2024
Closed
Closed
Closed
@volodya-lombrozo volodya-lombrozo added the soon This issue will be solved soon label Oct 4, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 4, 2024
@volodya-lombrozo
feat(objectionary#540): add unit test for computing max values
8b1c888
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 4, 2024
@volodya-lombrozo
feat(objectionary#540): prepare tests for max locals computing
8c75337
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 4, 2024
@volodya-lombrozo
feat(objectionary#540): add more logs to the tests
f3e0e20
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 4, 2024
@volodya-lombrozo
feat(objectionary#540): prepare more tests for lacal variables counting
57e00c1
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 4, 2024
@volodya-lombrozo
feat(objectionary#540): count max locas successfully
87657b6
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 4, 2024
@volodya-lombrozo
feat(objectionary#540): add more tricky methods
de12591
@volodya-lombrozo volodya-lombrozo mentioned this issue Oct 4, 2024
Merged
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 7, 2024
@volodya-lombrozo
feat(objectionary#540): add naive implementation of the stack computa…
79098f8 
…tion
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 7, 2024
@volodya-lombrozo
feat(objectionary#540): add more opcode stack changes
76d93be
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 7, 2024
@volodya-lombrozo
feat(objectionary#540): first approximate implementation of stack cal…
09ed31b 
…culation
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 7, 2024
@volodya-lombrozo
feat(objectionary#540): add even more test examples
01d1993
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 7, 2024
@volodya-lombrozo
feat(objectionary#540): all the integration tests are failed
58d5b7b
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 7, 2024
@volodya-lombrozo
feat(objectionary#540): break the unit test
a08e074
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 7, 2024
@volodya-lombrozo
feat(objectionary#540): repair several unit tests
029d4da
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 7, 2024
@volodya-lombrozo
feat(objectionary#540): fix the bug related to LDC type determination
34afa42
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 7, 2024
@volodya-lombrozo
feat(objectionary#540): correct stack size for multiarray
1af55fe
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 7, 2024
@volodya-lombrozo
feat(objectionary#540): correct stack size for tableswitch and lookup…
26113b9 
…switch
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 8, 2024
@volodya-lombrozo
feat(objectionary#540): ugly implementation of the worklist
e416553
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 8, 2024
@volodya-lombrozo
feat(objectionary#540): find the problem with invokedynamic instructions
9818f17
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 8, 2024
@volodya-lombrozo
feat(objectionary#540): fix the problem with invocedynamic instruction
9430a37
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 8, 2024
@volodya-lombrozo
feat(objectionary#540): fix the bug with max_locals computation
6e5e7bd
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 8, 2024
@volodya-lombrozo
feat(objectionary#540): fix all the unit and integration tests
74fbcd1
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 8, 2024
@volodya-lombrozo
feat(objectionary#540): fix several small problems with the implement…
8d80d6b 
…ation
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 8, 2024
@volodya-lombrozo
feat(objectionary#540): identify one more problem
8b59cfb
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 8, 2024
@volodya-lombrozo
feat(objectionary#540): handle goto instructions properly
bd15c5a
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 9, 2024
@volodya-lombrozo
feat(objectionary#540): add one more test case that identifies the pr…
475a01f 
…oblem
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 9, 2024
@volodya-lombrozo
feat(objectionary#540): fix the bug with local variables computation
c9efccb
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 9, 2024
@volodya-lombrozo
feat(objectionary#540): add one more interesting test
86158ec
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 9, 2024
@volodya-lombrozo
feat(objectionary#540): try to computeMaxLocalsWithCFG
3c2cab0
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 9, 2024
@volodya-lombrozo
feat(objectionary#540): fix all the rest mistakes in locals computation
0bef809
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 9, 2024
@volodya-lombrozo
feat(objectionary#540): disable parallelism temporarily
3fca43e
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 10, 2024
@volodya-lombrozo
feat(objectionary#540): one more implementation of locals counting
dff5cf8
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 10, 2024
@volodya-lombrozo
feat(objectionary#540): almost finished with try-catches and max_loca…
7f43c43 
…l calculations. Try-with-resources remains
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 10, 2024
@volodya-lombrozo
feat(objectionary#540): accuratly handle try-with-resources blocks
dd76e0e
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 10, 2024
@volodya-lombrozo
feat(objectionary#540): find the problem related to hiddent try-block…
f8077ed 
…s inside methods
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 10, 2024
@volodya-lombrozo
feat(objectionary#540): add one more ad-hoc solution to solve the pro…
2e75c9d 
…blem with variables size
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 10, 2024
@volodya-lombrozo
feat(objectionary#540): remove redundant code
da3d698
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 10, 2024
@volodya-lombrozo
feat(objectionary#540): add one more puzzle
61b26b4
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 10, 2024
@volodya-lombrozo
feat(objectionary#540): move locals computation to a separate class M…
980a484 
…axLocals
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 10, 2024
@volodya-lombrozo
feat(objectionary#540): move stack computation to a separate class Ma…
32ab14f 
…xStack
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 10, 2024
@volodya-lombrozo
feat(objectionary#540): add InstructionsFlow class
a8312df
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 10, 2024
@volodya-lombrozo
feat(objectionary#540): use InstructionsFlow in MaxLocals
989be65
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 10, 2024
@volodya-lombrozo
feat(objectionary#540): add more javadocs
4dfec30
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 10, 2024
@volodya-lombrozo
feat(objectionary#540): add more javadocs
972a3ce
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 10, 2024
@volodya-lombrozo
feat(objectionary#540): remove redundant method
04de627
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 10, 2024
@volodya-lombrozo
feat(objectionary#540): add javadocs
94b1976
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 10, 2024
@volodya-lombrozo
feat(objectionary#540): fix most of the code offences
7bd530a
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 10, 2024
@volodya-lombrozo
feat(objectionary#540): fix all the code offences
7b53e91
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 10, 2024
@volodya-lombrozo
feat(objectionary#540): add one more suppression
12ea088
This was referenced Oct 10, 2024
Open
Closed
Closed
@0pdd
Copy link
Author

0pdd commented Oct 10, 2024

@0pdd 3 puzzles #750, #751, #752 are still not solved.

@0pdd
Copy link
Author

0pdd commented Oct 11, 2024

@0pdd the puzzle #750 is still not solved; solved: #751, #752.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
soon This issue will be solved soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#540): Compute Max Locals And Stack volodya-lombrozo/jeo-maven-plugin
2 participants
@0pdd @volodya-lombrozo