Skip to content

Commit

Permalink
feat(#162): remove the puzzle for 162 issue
Browse files Browse the repository at this point in the history
  • Loading branch information
volodya-lombrozo committed Oct 27, 2023
1 parent 650478a commit b22bde4
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,8 @@
* You can find the description of the optimization right
* <a href="https://github.com/objectionary/jeo-maven-plugin/issues/102">here</a>
* @since 0.1.0
* @todo #157:90min ImprovementDistilledObjects is needed to be refactored.
* Right now it's a big class with a lot of methods, repetition and high complexity.
* We need to refactor it into a set of smaller classes and remove all
* linter warnings.
* @checkstyle NestedIfDepthCheck (500 lines)
* @checkstyle NestedForDepthCheck (500 lines)
*/
@SuppressWarnings({"PMD.CollapsibleIfStatements", "PMD.AvoidDuplicateLiterals"})
@SuppressWarnings("PMD.AvoidDuplicateLiterals")
public final class ImprovementDistilledObjects implements Improvement {
@Override
public Collection<? extends Representation> apply(
Expand Down Expand Up @@ -127,6 +121,7 @@ private static Representation replaceConstructors(
* @param target What should be replaced.
* @param replacement Replacement.
* @checkstyle ModifiedControlVariableCheck (200 lines)
* @checkstyle NestedForDepthCheck (200 lines)
*/
private static void replace(
final XmlClass clazz,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,10 @@ public List<XmlInstruction> instructionsWithout(final int... opcodes) {
* Method instructions.
* @param predicates Filters.
* @return Instructions.
* @todo #162:30min Simplify instructions method.
* This method is too complex. We should simplify it.
* In order to do so we can use {@link XmlNode} class.
* Don't forget to remove the puzzle.
*/
@SafeVarargs
public final List<XmlInstruction> instructions(final Predicate<XmlInstruction>... predicates) {
Expand Down

5 comments on commit b22bde4

@0pdd
Copy link

@0pdd 0pdd commented on b22bde4 Oct 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 157-2a1100ad disappeared from src/main/java/org/eolang/jeo/improvement/ImprovementDistilledObjects.java), that's why I closed #162. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.

@0pdd
Copy link

@0pdd 0pdd commented on b22bde4 Oct 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 162-5bafdc8f discovered in src/main/java/org/eolang/jeo/improvement/ImprovementDistilledObjects.java) and submitted as #204. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

@0pdd
Copy link

@0pdd 0pdd commented on b22bde4 Oct 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 162-ac76c1ae discovered in src/main/java/org/eolang/jeo/improvement/ImprovementDistilledObjects.java) and submitted as #205. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

@0pdd
Copy link

@0pdd 0pdd commented on b22bde4 Oct 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 162-3f123ad3 discovered in src/main/java/org/eolang/jeo/improvement/ImprovementDistilledObjects.java) and submitted as #206. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

@0pdd
Copy link

@0pdd 0pdd commented on b22bde4 Oct 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 162-93c5a72c discovered in src/main/java/org/eolang/jeo/representation/xmir/XmlMethod.java) and submitted as #207. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

Please sign in to comment.