feat(#175): fix all qulice suggestions

objectionary · Oct 26, 2023 · 90aa096 · 90aa096
1 parent 789285b
commit 90aa096
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 23 deletions.
diff --git a/src/main/java/org/eolang/jeo/improvement/ImprovementDistilledObjects.java b/src/main/java/org/eolang/jeo/improvement/ImprovementDistilledObjects.java
@@ -179,14 +179,13 @@ private static void replace(
      *  It's not correct, because we need to handle arguments correctly.
      */
     private static void replaceArguments(final XmlClass clazz) {
-        clazz.methods().stream()
+        clazz.methods()
+            .stream()
             .map(XmlMethod::instructions)
             .flatMap(Collection::stream)
             .forEach(
-                instruction -> instruction.replaceArguementsValues(
-                    "org/eolang/jeo/B",
-                    "org/eolang/jeo/A$B"
-                )
+                instruction ->
+                    instruction.replaceArguementsValues("org/eolang/jeo/B", "org/eolang/jeo/A$B")
             );
     }
 
@@ -441,11 +440,9 @@ private void handleRootObject(final Node root, final String bytename) {
                                 if (base.getNodeValue().equals("seq")) {
                                     final NodeList instructions = item.getChildNodes();
                                     for (int inst = 0; inst < instructions.getLength(); ++inst) {
-                                        new XmlInstruction(instructions.item(inst))
-                                            .replaceArguementsValues(
-                                                this.decorated.name(),
-                                                bytename
-                                            );
+                                        new XmlInstruction(
+                                            instructions.item(inst)
+                                        ).replaceArguementsValues(this.decorated.name(), bytename);
                                     }
                                 }
                             }

diff --git a/src/main/java/org/eolang/jeo/representation/xmir/XmlInstruction.java b/src/main/java/org/eolang/jeo/representation/xmir/XmlInstruction.java
@@ -47,6 +47,10 @@ public final class XmlInstruction {
     @SuppressWarnings("PMD.AvoidFieldNameMatchingMethodName")
     private final Node node;
 
+    /**
+     * Constructor.
+     * @param xml XML node as String.
+     */
     public XmlInstruction(final String xml) {
         this(new XMLDocument(xml).node().getFirstChild());
     }
@@ -96,19 +100,6 @@ public Object[] arguments() {
         return XmlInstruction.arguments(this.node);
     }
 
-    /**
-     * XML node.
-     * @return XML node.
-     * @todo #157:90min Hide internal node representation in XmlInstruction.
-     *  This class should not expose internal node representation.
-     *  We have to consider to add methods or classes in order to avoid
-     *  exposing internal node representation.
-     */
-    @SuppressWarnings("PMD.AvoidFieldNameMatchingMethodName")
-    Node node() {
-        return this.node;
-    }
-
     @Override
     public boolean equals(final Object other) {
         final boolean result;
@@ -133,6 +124,19 @@ public String toString() {
         return new XMLDocument(this.node).toString();
     }
 
+    /**
+     * XML node.
+     * @return XML node.
+     * @todo #157:90min Hide internal node representation in XmlInstruction.
+     *  This class should not expose internal node representation.
+     *  We have to consider to add methods or classes in order to avoid
+     *  exposing internal node representation.
+     */
+    @SuppressWarnings("PMD.AvoidFieldNameMatchingMethodName")
+    Node node() {
+        return this.node;
+    }
+
     /**
      * Get opcode arguments.
      * @param node Node.

diff --git a/src/main/java/org/eolang/jeo/representation/xmir/XmlNode.java b/src/main/java/org/eolang/jeo/representation/xmir/XmlNode.java
@@ -69,6 +69,10 @@ XmlNode child(final String name) {
         throw this.notFound(name);
     }
 
+    /**
+     * Get all child nodes.
+     * @return Child nodes.
+     */
     Stream<XmlNode> children() {
         return this.objects().map(XmlNode::new);
     }
@@ -81,10 +85,18 @@ XmlClass toClass() {
         return new XmlClass(this.node);
     }
 
+    /**
+     * Retrieve node text content.
+     * @return Text content.
+     */
     String text() {
         return this.node.getTextContent();
     }
 
+    /**
+     * Set node text content.
+     * @param text Text content.
+     */
     void withText(final String text) {
         this.node.setTextContent(text);
     }