Skip to content

Commit

Permalink
Merge branch '__rultor'
Browse files Browse the repository at this point in the history
  • Loading branch information
rultor committed Oct 27, 2023
2 parents 53063c2 + 863d369 commit 86da06d
Show file tree
Hide file tree
Showing 2 changed files with 79 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,6 @@ public XmlClass(final Node xml) {
/**
* Retrieve all constructors from XMIR.
* @return List of constructors.
* @todo #167:60min Add unit tests for 'constructors' method.
* Currently we don't have unit tests for that method. So, it makes sense to add
* them to keep code safe and clear.
*/
public List<XmlMethod> constructors() {
return this.objects().filter(
Expand Down
79 changes: 79 additions & 0 deletions src/test/java/org/eolang/jeo/representation/xmir/XmlClassTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
/*
* The MIT License (MIT)
*
* Copyright (c) 2016-2023 Objectionary.com
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included
* in all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
* SOFTWARE.
*/
package org.eolang.jeo.representation.xmir;

import com.jcabi.xml.XML;
import com.jcabi.xml.XMLDocument;
import org.hamcrest.MatcherAssert;
import org.hamcrest.Matchers;
import org.junit.jupiter.api.Test;

/**
* Test case for {@link XmlClass}.
* @since 0.1
*/
class XmlClassTest {

@Test
void retrievesConstructor() {
final XML doc = new XMLDocument(
String.join(
"",
"<o name='FooClass'>",
"<o name='new'>",
"</o></o>"
)
);
MatcherAssert.assertThat(
String.format(
"%s should retrieve exactly one constructor from %n%s%n",
XmlClass.class.getSimpleName(),
doc
),
new XmlClass(doc.node().getFirstChild()).constructors(),
Matchers.hasSize(1)
);
}

@Test
void doesNotRetrieveConstructor() {
final XML doc = new XMLDocument(
String.join(
"",
"<o name='BarClass'>",
"<o name='bar'>",
"</o></o>"
)
);
MatcherAssert.assertThat(
String.format(
"%s should not retrieve any constructor from %n%s%n",
XmlClass.class.getSimpleName(),
doc
),
new XmlClass(doc.node().getFirstChild()).constructors(),
Matchers.empty()
);
}
}

1 comment on commit 86da06d

@0pdd
Copy link

@0pdd 0pdd commented on 86da06d Oct 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 167-7638dd7e disappeared from src/main/java/org/eolang/jeo/representation/xmir/XmlClass.java), that's why I closed #185. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.

Please sign in to comment.