Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add inner helpful classes in Expect #3833

Merged

Conversation

asmirnov-backend
Copy link
Contributor

Ref: #3461

Inner classes help to encapsulate the logic of using Expect and make it easier.

Before:

Expect.at(this, Attr.RHO)
    .that(phi -> new Dataized(phi).asNumber())
    .otherwise("must be a number")
    .it();

After:

new Expect.Number(Expect.at(this, Attr.RHO)).it();

Ref to comment

@yegor256
Copy link
Member

@asmirnov-backend thanks! One comment above. Also, check this one: https://www.yegor256.com/2024/04/01/ping-me-please.html

@asmirnov-backend
Copy link
Contributor Author

@yegor256 thanks for review! Comment resolved. Could you please rereview

@yegor256 yegor256 merged commit f4aabe2 into objectionary:master Jan 19, 2025
22 checks passed
@yegor256
Copy link
Member

@asmirnov-backend thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants