feat(#3744): Human-Readable Error Message for Prohibited Comment in an Object Definition #3818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxonfjvipon Could you review this one, please? |
maxonfjvipon
requested changes
Jan 15, 2025
volodya-lombrozo
changed the title
Eo.g4 Grammar Definition of objects Rule
|
@yegor256 Could you review these changes, please? |
maxonfjvipon
approved these changes
Jan 16, 2025
|
@yegor256 Friendly reminder |
yegor256
added a commit
that referenced
this pull request
Jan 17, 2025
|
@volodya-lombrozo thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another approach for the same problem that I tried to solve recently:
#3802
Actually, in this PR I change the
objectsrule definition from:to:
It helps to catch a more inforamtive parsing errors (see tests with examples.)
Closes: #3744