fix(#3793): Fix Expect #3795
Draft
fix(#3793): Fix Expect #3795
+121
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmirnov-backend
force-pushed
the
fix/#3793/fix-expect
branch
from
8b7e6aa to
0b1ae1e
Compare
yegor256
reviewed
Jan 8, 2025
| * | ||
| * @since 0.51 | ||
| */ | ||
| class ExpectFailureInMust extends ExFailure { |
There was a problem hiding this comment.
@asmirnov-backend maybe it's better to make them nested classes, inside Expect?
There was a problem hiding this comment.
Thanks for comment!
Unfortunately, the Expect<T> class can not contain nested exceptions, because Expect<T> is a generic class.
Possible solutions:
- Leave exceptions in separate classes
- Remove generic from
Expectand make it works only withPhi - Use static (But static is bad👎, I do not know is it ok to use it here).
private static class ExpectFailureInThat extends ExFailure
@yegor256 Which solution do you want to choose?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #3793
Now Expect is "fail fast" and the error message is only for one fail