-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add AtRhoTest #3784
base: master
Are you sure you want to change the base?
add AtRhoTest #3784
Conversation
@sunmisc we can easily forgive you for the long absence, but can't forgive the wrong formatting of the code :) our checkers won't let us merge your code until all builds are green |
Phew, 2025 in copyright is an error, which is probably weird. |
The actual test fails because of the race. |
@yegor256 In fact, we can assume that the AtRho object is not thread-safe and then this test can be removed. But inside this object AtomicReference is used, even with considerations that it is for the sake of elegance, there are more efficient methods for working in one thread - setPlain / getPlain It's not quite clear what the object should end up being thread-safe/not thread-safe, you should adjust this, either to optimize or to fix a race bug |
@sunmisc as a rule of thumb, if you see a bug in master branch, report a new issue, don't try to fix it in your branch |
I apologize for my long absence.
I also want to apologize for possible non-compliance with the code format, and other errors. I do not use this product yet, but only had a quick look at the code
This test is a continuation of #3723