Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AtRhoTest #3784

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

add AtRhoTest #3784

wants to merge 9 commits into from

Conversation

sunmisc
Copy link

@sunmisc sunmisc commented Jan 2, 2025

I apologize for my long absence.
I also want to apologize for possible non-compliance with the code format, and other errors. I do not use this product yet, but only had a quick look at the code

This test is a continuation of #3723

@yegor256
Copy link
Member

yegor256 commented Jan 2, 2025

@sunmisc we can easily forgive you for the long absence, but can't forgive the wrong formatting of the code :) our checkers won't let us merge your code until all builds are green

@sunmisc
Copy link
Author

sunmisc commented Jan 2, 2025

@sunmisc we can easily forgive you for the long absence, but can't forgive the wrong formatting of the code :) our checkers won't let us merge your code until all builds are green

Phew, 2025 in copyright is an error, which is probably weird.
The rest of the formatting rules are pretty unfamiliar to me, but I respect them anyway and I kind of like them.

@sunmisc
Copy link
Author

sunmisc commented Jan 2, 2025

@sunmisc we can easily forgive you for the long absence, but can't forgive the wrong formatting of the code :) our checkers won't let us merge your code until all builds are green

Phew, 2025 in copyright is an error, which is probably weird. The rest of the formatting rules are pretty unfamiliar to me, but I respect them anyway

The actual test fails because of the race.

@sunmisc
Copy link
Author

sunmisc commented Jan 2, 2025

@yegor256 In fact, we can assume that the AtRho object is not thread-safe and then this test can be removed. But inside this object AtomicReference is used, even with considerations that it is for the sake of elegance, there are more efficient methods for working in one thread - setPlain / getPlain

It's not quite clear what the object should end up being thread-safe/not thread-safe, you should adjust this, either to optimize or to fix a race bug

@yegor256
Copy link
Member

yegor256 commented Jan 3, 2025

@sunmisc as a rule of thumb, if you see a bug in master branch, report a new issue, don't try to fix it in your branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants