Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(#3780): join ShakeMojo and OptimizeMojo #3781

Merged
merged 8 commits into from
Dec 30, 2024
Merged

bug(#3780): join ShakeMojo and OptimizeMojo #3781

merged 8 commits into from
Dec 30, 2024

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Dec 29, 2024 •
edited
Loading

Changes in this PR:

  1. Renamed the parameter trackOptimizationSteps to trackTransformationSteps
  2. Joined OptimizeMojo and ShakeMojo into single ShakeMojo
  3. Removed unnecessary classes like OptTrain, OptSpy
  4. Renamed TrParsing to TrShaking and moved it to eo-maven-plugin since it's used only there
  5. Introduced TrFull that contains full logging during XSL transformations. The train is used in all the possible places
  6. Renamed SpyTrain to TrSpy
  7. Renamed some resources directories with more appropriate names
  8. Cleared up some eo packs and moved the to appropriate directories
  9. Removed public from as many classes in eo-maven-plugin as possible

Closes: #3780

@github-actions github-actions bot added the core label Dec 29, 2024
@maxonfjvipon maxonfjvipon marked this pull request as draft December 29, 2024 16:17
@maxonfjvipon maxonfjvipon marked this pull request as draft December 29, 2024 16:17
@maxonfjvipon maxonfjvipon marked this pull request as ready for review December 29, 2024 20:05
@maxonfjvipon
Copy link
Member Author

@yegor256 please check

@maxonfjvipon maxonfjvipon changed the title bug(#3790): join ShakeMojo and OptimizeMojo bug(#3780): join ShakeMojo and OptimizeMojo Dec 29, 2024
yegor256
yegor256 approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@yegor256 yegor256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxonfjvipon cool!

@yegor256 yegor256 added this pull request to the merge queue Dec 30, 2024
Merged via the queue into objectionary:master with commit e61b39b Dec 30, 2024
21 checks passed
@maxonfjvipon maxonfjvipon mentioned this pull request Dec 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yegor256 yegor256 yegor256 approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OptimizeMojo and ShakeMojo can be joined
2 participants
@maxonfjvipon @yegor256