-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#3756): Use a Single Format for All Error Messages #3762
feat(#3756): Use a Single Format for All Error Messages #3762
Conversation
@yegor256 Could you review these changes, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@volodya-lombrozo looks good, just one comment above
…sage -> MsgUnderlined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@volodya-lombrozo thanks! |
@volodya-lombrozo Thanks for the contribution! You've earned +4 points for this: +4 as a basis; -8 for too many hits-of-code (203 >= 200); -4 for very few (4) comments; +12 to give you at least something. Please, keep them coming. |
Created one more class
LocationMessage
that is used as a default error message:It simply adds line and column where an error occured.
PS. Now we have two classes
UnderlinedMessage
andLocationMessage
. They both have the same structure and similar methods. So, we can create an interface for them.Moreover, we can change their names to
MsgUnderlined
andMsgLocation
. I haven't done it in this PR in order to keep its size in some borders.But we can change it during the PR review.
Closes: #3756.