Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#3756): Use a Single Format for All Error Messages #3762

Merged
merged 5 commits into from
Dec 26, 2024

Conversation

volodya-lombrozo
Copy link
Member

Created one more class LocationMessage that is used as a default error message:

[2:0] error: 'Invalid program declaration'

It simply adds line and column where an error occured.


PS. Now we have two classes UnderlinedMessage and LocationMessage. They both have the same structure and similar methods. So, we can create an interface for them.
Moreover, we can change their names to MsgUnderlined and MsgLocation. I haven't done it in this PR in order to keep its size in some borders.
But we can change it during the PR review.

Closes: #3756.

@volodya-lombrozo
Copy link
Member Author

@yegor256 Could you review these changes, please?

Copy link
Member

@yegor256 yegor256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@volodya-lombrozo looks good, just one comment above

@volodya-lombrozo
Copy link
Member Author

@yegor256 Renamed classes according with your suggestions: 829f334
Can you have a look one more time, please?

Copy link
Member

@yegor256 yegor256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yegor256 yegor256 added this pull request to the merge queue Dec 26, 2024
@yegor256
Copy link
Member

@volodya-lombrozo thanks!

Merged via the queue into objectionary:master with commit d5de9b0 Dec 26, 2024
21 checks passed
@0crat
Copy link

0crat commented Dec 26, 2024

@volodya-lombrozo Thanks for the contribution! You've earned +4 points for this: +4 as a basis; -8 for too many hits-of-code (203 >= 200); -4 for very few (4) comments; +12 to give you at least something. Please, keep them coming.

@0crat
Copy link

0crat commented Dec 26, 2024

@yegor256 Thanks for the review! You've earned +4 points for this: +4 as a basis; -10 for very few (4) comments; +10 to give you at least something. Your running balance is -16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnderlinedMessage.java:43-45: Add more decorators for the...
3 participants