Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#3706): Identify a Rule Where an Error Occurred #3741

Merged
merged 9 commits into from
Dec 23, 2024

Conversation

volodya-lombrozo
Copy link
Member

In this PR I:

  1. Used Recognizer<?, ?> recognizer to retrieve the place where a syntax error occured.
  2. Added more examples to unit test to show the current state of error message printing.
  3. Added a few more puzzles to mitigate some future improvements.

Closes: #3706.

@volodya-lombrozo
Copy link
Member Author

@maxonfjvipon Could you review these changes, please?

@volodya-lombrozo volodya-lombrozo changed the title feat(#3706): Identify Place Where an Error Occured feat(#3706): Identify a Rule Where an Error Occurred Dec 23, 2024
Copy link
Member

@maxonfjvipon maxonfjvipon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@volodya-lombrozo in many cases the description is not really related to the syntax error, but in general it all looks good, thanks!

@yegor256 yegor256 added this pull request to the merge queue Dec 23, 2024
Merged via the queue into objectionary:master with commit bc3cebd Dec 23, 2024
21 checks passed
@yegor256
Copy link
Member

@volodya-lombrozo thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ParsingErrors.java:87-90: Add more specific error...
3 participants