Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(#3698): Remove object versioning #3699

Merged

Conversation

maxonfjvipon
Copy link
Member

Closes: #3698

@github-actions github-actions bot added the core label Dec 18, 2024
@maxonfjvipon
Copy link
Member Author

@yegor256 please check

@yegor256
Copy link
Member

@maxonfjvipon why removing all integration tests for maven plugin??

@maxonfjvipon
Copy link
Member Author

maxonfjvipon commented Dec 18, 2024

@yegor256

  1. they are already disabled for a long time (almost a year) and everything works fine
image
  1. some of them are not relevant anymore, for example rewritten_sources or hash_package_layer
  2. some of them are already implemented as unit tests
  3. we have Jaxec now, so if something goes wrong in the future - we can use it instead

I don't see any reason to keep them anymore

@yegor256
Copy link
Member

@maxonfjvipon well, it's a good practice (and a very very common practice) to use invoker for Maven plugin testing. It's just something people always do in Maven world. I suggest keeping one of them in place (fibonacci, for example) and getting rid of all others. WDYT?

@maxonfjvipon
Copy link
Member Author

@yegor256 please check one more time, I fixed fibonacci integration test and enabled it

@yegor256 yegor256 merged commit 356d553 into objectionary:master Dec 19, 2024
20 checks passed
@yegor256
Copy link
Member

@maxonfjvipon perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove current implementation of objection versioning
2 participants