Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#3257): update jcabi-xml and fix tests #3444

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Oct 29, 2024

Ref: #3257


PR-Codex overview

This PR updates the version of jcabi-xml in pom.xml, adds new imports in ParseMojoTest.java, and modifies several test methods to improve error detection and handling. It also removes unused methods related to message parsing and regex creation.

Detailed summary

  • Updated jcabi-xml version from 0.29.0 to 0.29.1.
  • Added imports for Files, Path, and FileTime in ParseMojoTest.java.
  • Enhanced error detection in doesNotFailWithNoErrorsAndWarnings, detectsErrorsSuccessfully, detectsCriticalErrorsSuccessfully, and detectsWarningWithCorrespondingFlag methods.
  • Removed unused methods getMessage and createRegEx from ParseMojoTest.java.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@yegor256 please check

@yegor256 yegor256 merged commit 2e93638 into objectionary:master Oct 29, 2024
20 checks passed
@0crat
Copy link

0crat commented Oct 31, 2024

@maxonfjvipon Thanks for your contribution! Here's how your +4 points were calculated: +4 base, +8 for 166 hits-of-code, -16 for no code review, -4 for only 1 comment, and +12 to meet the minimum reward. To maximize future rewards, aim for code reviews and encourage more reviewer comments. Keep up the good work! Your balance is now +12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants