Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#3251): console object + some inputs/outputs objects #3292

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Jul 28, 2024

Ref: #3251

What's done:

  • Introduced console object which can read from and write to standard operating system console
  • Objects stdout and stdin are implemented in EO and uses the object console
  • Introduced bytes-as-input object
  • Introduced malloc-as-output object
  • Introduced uname object which represents operating system name
  • Introduced line-separator object which returns "\n" of unix OS and "\r\n" for windows OS
  • Fixed some documentation
  • Some objects are pretty formatted

PR-Codex overview

This PR focuses on adding new objects and improving existing ones in the EO language runtime.

Detailed summary

  • Added while object for loop functionality
  • Updated stdout object in io package
  • Added range object constructor
  • Updated dependencies in SnippetTestCase.java
  • Improved malloc object functionality

The following files were skipped due to too many changes: eo-runtime/src/main/eo/org/eolang/txt/regex.eo, eo-runtime/src/test/eo/org/eolang/sys/uname-test.eo, eo-runtime/src/test/eo/org/eolang/io/console-tests.eo, eo-runtime/src/main/java/EOorg/EOeolang/EOio/EOstdout.java, eo-runtime/src/test/eo/org/eolang/io/bytes-as-input-test.eo, eo-runtime/src/main/eo/org/eolang/sys/line-separator.eo, eo-runtime/src/main/eo/org/eolang/sys/uname.eo, eo-runtime/src/test/eo/org/eolang/io/malloc-as-output-test.eo, eo-runtime/src/main/eo/org/eolang/io/stdin.eo, eo-runtime/src/main/eo/org/eolang/txt/text.eo, eo-runtime/src/test/java/EOorg/EOeolang/EOnumberTest.java, eo-runtime/src/main/java/EOorg/EOeolang/EOio/Input.java, eo-runtime/src/main/eo/org/eolang/io/malloc-as-output.eo, eo-runtime/src/main/eo/org/eolang/io/bytes-as-input.eo, eo-runtime/src/main/eo/org/eolang/io/console.eo, eo-runtime/src/test/java/EOorg/EOeolang/EOio/EOstdinTest.java, eo-runtime/src/test/java/EOorg/EOeolang/EOio/EOconsoleTest.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@yegor256 please check

Copy link
Member

@yegor256 yegor256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rultor merge

@maxonfjvipon
Copy link
Member Author

@rultor status

@rultor
Copy link
Contributor

rultor commented Jul 29, 2024

@rultor status

@maxonfjvipon This is what's going on here:

  • no new requests registered
  • build is not running

More information about Rultor commands you can get here.

@yegor256 yegor256 merged commit ae6245c into objectionary:master Jul 29, 2024
22 checks passed
@0crat
Copy link

0crat commented Jul 29, 2024

@yegor256 Thanks for the review! You've earned +55 points for this: +25 as a basis; +40 for the 1586 hits-of-code that you reviewed; -10 for too few (1) comments. Your running balance is +157.

@0crat
Copy link

0crat commented Jul 29, 2024

@maxonfjvipon Thanks for the contribution! You've earned +5 points for this: +30 as a basis; -7 for too many hits-of-code (1586 >= 100); -15 for way too many hits-of-code (1586 >= 400); -10 for too few (3) comments; +7 to give you at least something. Please, keep them coming. Your running balance is +180.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants