-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3145: More concise detecting of rust inserts #3161
Conversation
@maxonfjvipon please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@levBagryansky let's add test pack for xsl stylesheet that would check if dependencies were added (something similar to https://github.com/objectionary/eo/blob/master/eo-maven-plugin/src/test/resources/org/eolang/maven/binarize/add_rust/add-dependencies.yaml). It will allow us to catch the problem before eo-runtime
compilation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@levBagryansky looks good, thanks
@levBagryansky now, all |
@levBagryansky or restart CI to see what's missing |
@yegor256 please check |
@rultor merge |
Closes #3145
PR-Codex overview
This PR improves error handling and refactors Rust code insertion.
Detailed summary
BinarizeParseTest
EOrust