Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3145: More concise detecting of rust inserts #3161

Merged
merged 9 commits into from
May 6, 2024

Conversation

levBagryansky
Copy link
Member

@levBagryansky levBagryansky commented May 2, 2024

Closes #3145


PR-Codex overview

This PR improves error handling and refactors Rust code insertion.

Detailed summary

  • Updated error message in BinarizeParseTest
  • Improved error handling in EOrust
  • Restructured Rust code insertion logic in XSL
  • Added detailed YAML test for Rust code detection and insertion

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@levBagryansky
Copy link
Member Author

@maxonfjvipon please review

Copy link
Member

@maxonfjvipon maxonfjvipon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@levBagryansky let's add test pack for xsl stylesheet that would check if dependencies were added (something similar to https://github.com/objectionary/eo/blob/master/eo-maven-plugin/src/test/resources/org/eolang/maven/binarize/add_rust/add-dependencies.yaml). It will allow us to catch the problem before eo-runtime compilation

@levBagryansky levBagryansky requested a review from maxonfjvipon May 6, 2024 09:42
Copy link
Member

@maxonfjvipon maxonfjvipon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@levBagryansky looks good, thanks

@yegor256
Copy link
Member

yegor256 commented May 6, 2024

@levBagryansky now, all .yaml files must have a header with a license. Please, add one, to make it possible to merge.

@maxonfjvipon
Copy link
Member

@levBagryansky or restart CI to see what's missing

@levBagryansky
Copy link
Member Author

@yegor256 please check

@yegor256
Copy link
Member

yegor256 commented May 6, 2024

@rultor merge

@rultor
Copy link
Contributor

rultor commented May 6, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 423270c into objectionary:master May 6, 2024
21 checks passed
@rultor
Copy link
Contributor

rultor commented May 6, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 22min)

@levBagryansky levBagryansky deleted the 3145-rust_detecting branch May 7, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BinarizeMojo does not add dependencies into EO code after unphi
4 participants