Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2974 enable try tests #2987

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Conversation

levBagryansky
Copy link
Member

@levBagryansky levBagryansky commented Mar 20, 2024

closes #2974
I do not know why 3 was there


PR-Codex overview

This PR focuses on enabling try tests in the eo-runtime module by updating the test cases affected by changes in the rho attribute immutability.

Detailed summary

  • Enabled try tests in try-tests.eo.
  • Updated test cases simple-division-by-zero and try-memory-update.
  • Modified test case try-memory-update-catch.
  • Adjusted values and assertions in the tests.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@levBagryansky
Copy link
Member Author

@maxonfjvipon please check

Copy link
Member

@maxonfjvipon maxonfjvipon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@levBagryansky that's really strange, because this 3 was there since the test was introduced

@levBagryansky
Copy link
Member Author

@yegor256 please take a look

@yegor256
Copy link
Member

@rultor merge

@maxonfjvipon
Copy link
Member

@rultor status

@rultor
Copy link
Contributor

rultor commented Mar 21, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Contributor

rultor commented Mar 21, 2024

@rultor status

@maxonfjvipon This is what's going on here:

  • request 2009982987 is in processing, command is merge
  • request has 6 parameter(s):
  • fork: [email protected]:levBagryansky/eo.git
  • fork_branch: 2974_enable-try-tests
  • head: [email protected]:objectionary/eo.git
  • head_branch: master
  • pull_id: 2987
  • pull_title: 2974 enable try tests
  • build is not running

More information about Rultor commands you can get here.

@rultor rultor merged commit 8e914d7 into objectionary:master Mar 21, 2024
16 checks passed
@rultor
Copy link
Contributor

rultor commented Mar 21, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 20min)

@levBagryansky levBagryansky deleted the 2974_enable-try-tests branch March 21, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

try-tests.eo:30-32: Enable try tests. The tests were...
4 participants