Added check if there are atoms, but no +rt meta. #2986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxonfjvipon could you check this one, please? |
maxonfjvipon
requested changes
Mar 20, 2024
| <xsl:attribute name="severity"> | ||
| <xsl:text>error</xsl:text> | ||
| </xsl:attribute> | ||
| <xsl:text>Using atoms without +rt meta</xsl:text> |
There was a problem hiding this comment.
@c71n93 let's make this message more informative, like "Using atoms without +rt meta is prohibited"
maxonfjvipon
approved these changes
Mar 20, 2024
|
@yegor256 could you check this one, please |
|
@rultor merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2948
PR-Codex overview
The focus of this PR is to update error handling in the EO parser to enforce the presence of atoms with the +rt meta.
Detailed summary
rt-without-atomtort-and-atoms