Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for seq #2840

Merged
merged 9 commits into from
Apr 12, 2024
Merged

Conversation

c71n93
Copy link
Member

@c71n93 c71n93 commented Feb 2, 2024

Related to #2834


PR-Codex overview

This PR focuses on adding tests for single dataization int equal to methods in seq-tests.eo.

Detailed summary

  • Added test for seq-single-dataization-int-equal-to-test
  • Added test for seq-single-dataization-int-equal-to-cache-problem-test
  • Defined sequences and operations for testing
  • Checked equality and cache problems for single dataization with integers

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@yegor256
Copy link
Member

@c71n93 what's up with this one? ready for review?

@c71n93
Copy link
Member Author

c71n93 commented Feb 19, 2024

@yegor256 No, I think it isn't ready yet. This PR just adds some tests that are broken because of some issues with memory and caching (more in this issue #2834). We don't know how to fix this bug yet.

We have two options: merge this tests and leave todo for fixing them, or fix them in this PR. @yegor256 what is better?

@yegor256
Copy link
Member

@c71n93 @maxonfjvipon maybe this branch will work now, if you merge master into it?


# Test.
[] > seq-single-dataization-int-equal-to-test-bug
memory 0 > x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c71n93 @yegor256 some changes are required. (memory 0).alloc should be here

@c71n93
Copy link
Member Author

c71n93 commented Apr 11, 2024

@maxonfjvipon check please

@c71n93
Copy link
Member Author

c71n93 commented Apr 11, 2024

@maxonfjvipon it's strange, qulice did not notice this unused imports. I will fix it.

1

# Test.
[] > seq-single-dataization-int-equal-to-cache-problem-test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c71n93 I believe this test should work, maybe try to enable it?

@c71n93
Copy link
Member Author

c71n93 commented Apr 11, 2024

@yegor256 could you check this one, please?

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Apr 12, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 7c9fc5d into objectionary:master Apr 12, 2024
17 checks passed
@rultor
Copy link
Contributor

rultor commented Apr 12, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 18min)

@c71n93 c71n93 deleted the 2834-fix-bug-with-tuple-and-seq branch May 6, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants