Fix XMIR to EO data conversion #2770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxonfjvipon could you check this one, please? |
c71n93
force-pushed
the
2750-fixing-xmir-to-eo
branch
from
16f6a3d to
733cfa5
Compare
|
@maxonfjvipon I have fixed |
maxonfjvipon
requested changes
Jan 12, 2024
| @@ -142,17 +142,10 @@ SOFTWARE. | |||
| <xsl:text>"""</xsl:text> | |||
| </xsl:when> | |||
| <xsl:when test="@base='bool'"> | |||
There was a problem hiding this comment.
@c71n93 let's combine bool, int and float under one when condition
|
@yegor256 could you check this one, please? |
yegor256
reviewed
Jan 15, 2024
| new EoSyntax( | ||
| "test", new InputOf(source) | ||
| ).parsed() | ||
| return new Xsline(new TrClasspath<>( |
There was a problem hiding this comment.
@maxonfjvipon I'm curious, how does this line pass Qulice check? There is obviously an error. Maybe we have Qulice turned off for this module?
There was a problem hiding this comment.
@yegor256 @maxonfjvipon I have fixed the indentation, could you check, please?
maxonfjvipon
approved these changes
Jan 15, 2024
|
@rultor merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2750
PR-Codex overview
Detailed summary