Merge pull request #3803 from maxonfjvipon/bug/#3790/no-rho-after-lambda

bug(#3790): fixed `AtWithRho` performance problems + not set rho to lambda

eo-runtime/src/main/java/org/eolang/AtComposite.java

@@ -65,7 +65,7 @@ public Phi get() {
     }
 
     @Override
-    public boolean put(final Phi phi) {
+    public void put(final Phi phi) {
         throw new ExReadOnly(
             "Can't overwrite lambda expression"
         );

eo-runtime/src/main/java/org/eolang/AtLogged.java

@@ -87,10 +87,9 @@ public Phi get() {
     }
 
     @Override
-    public boolean put(final Phi src) {
+    public void put(final Phi src) {
         this.log.info(String.format("  %s.put()...\n", this.owner));
-        final boolean ret = this.origin.put(src);
+        this.origin.put(src);
         this.log.info(String.format("  %s.put()!\n", this.owner));
-        return ret;
     }
 }

eo-runtime/src/main/java/org/eolang/AtOnce.java

@@ -70,13 +70,12 @@ public Phi get() {
     }
 
     @Override
-    public boolean put(final Phi phi) {
+    public void put(final Phi phi) {
         throw new ExReadOnly(
             String.format(
                 "Can't overwrite the \"%s\" attribute",
                 this.origin
             )
         );
     }
-
 }

eo-runtime/src/main/java/org/eolang/AtRho.java

@@ -70,14 +70,9 @@ public Phi get() {
     }
 
     @Override
-    public boolean put(final Phi phi) {
-        final boolean ret;
+    public void put(final Phi phi) {
         if (this.rho.get() == null) {
             this.rho.set(phi);
-            ret = true;
-        } else {
-            ret = false;
         }
-        return ret;
     }
 }

eo-runtime/src/main/java/org/eolang/AtVoid.java

@@ -89,7 +89,7 @@ public Phi get() {
     }
 
     @Override
-    public boolean put(final Phi phi) {
+    public void put(final Phi phi) {
         if (this.object.get() == null) {
             this.object.set(phi);
         } else {
@@ -100,7 +100,5 @@ public boolean put(final Phi phi) {
                 )
             );
         }
-        return true;
     }
-
 }

eo-runtime/src/main/java/org/eolang/AtGetOnly.java → eo-runtime/src/main/java/org/eolang/AtWithRho.java

@@ -24,44 +24,51 @@
 
 package org.eolang;
 
-import java.util.function.Supplier;
-
 /**
- * Attribute that only gets objects.
- *
+ * The attribute that tries to copy object and set \rho to it if it has not already set.
  * @since 0.36.0
  */
-final class AtGetOnly implements Attr {
+final class AtWithRho implements Attr {
+    /**
+     * Original attribute.
+     */
+    private final Attr origin;
 
     /**
-     * Get object supplier.
+     * Rho.
      */
-    private final Supplier<Phi> function;
+    private final Phi rho;
 
     /**
      * Ctor.
-     * @param func Get object function
+     * @param attr Attribute
+     * @param rho Rho
      */
-    AtGetOnly(final Supplier<Phi> func) {
-        this.function = func;
+    AtWithRho(final Attr attr, final Phi rho) {
+        this.origin = attr;
+        this.rho = rho;
     }
 
     @Override
     public Attr copy(final Phi self) {
-        throw new UnsupportedOperationException(
-            "Should never happen"
+        return new AtWithRho(
+            this.origin.copy(self),
+            self
         );
     }
 
     @Override
     public Phi get() {
-        return this.function.get();
+        Phi ret = this.origin.get();
+        if (!ret.hasRho()) {
+            ret = ret.copy();
+            ret.put(Attr.RHO, this.rho);
+        }
+        return ret;
     }
 
     @Override
-    public boolean put(final Phi phi) {
-        throw new UnsupportedOperationException(
-            "Should never happen"
-        );
+    public void put(final Phi phi) {
+        this.origin.put(phi);
     }
 }

eo-runtime/src/main/java/org/eolang/AtomSafe.java

@@ -37,10 +37,10 @@ public final class AtomSafe implements Atom {
 
     /**
      * Ctor.
-     * @param atom Original atom.
+     * @param atom Phi as atom.
      */
-    public AtomSafe(final Atom atom) {
-        this.origin = atom;
+    public AtomSafe(final Phi atom) {
+        this.origin = (Atom) atom;
     }
 
     @Override

eo-runtime/src/main/java/org/eolang/Attr.java

@@ -56,6 +56,8 @@ public interface Attr {
     /**
      * Take the object out.
      *
+     * <p>If attribute is not set - throws {@link ExUnset}.</p>
+     *
      * @return The object
      */
     Phi get();
@@ -64,7 +66,6 @@ public interface Attr {
      * Put a new object in.
      *
      * @param phi The object to put
-     * @return Was attribute set
      */
-    boolean put(Phi phi);
+    void put(Phi phi);
 }

eo-runtime/src/main/java/org/eolang/Data.java

@@ -85,19 +85,24 @@ public Phi copy() {
             return this.object.copy();
         }
 
+        @Override
+        public boolean hasRho() {
+            return this.object.hasRho();
+        }
+
         @Override
         public Phi take(final String name) {
             return this.object.take(name);
         }
 
         @Override
-        public boolean put(final int pos, final Phi obj) {
-            return this.object.put(pos, obj);
+        public void put(final int pos, final Phi obj) {
+            this.object.put(pos, obj);
         }
 
         @Override
-        public boolean put(final String name, final Phi obj) {
-            return this.object.put(name, obj);
+        public void put(final String name, final Phi obj) {
+            this.object.put(name, obj);
         }
 
         @Override