Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a single syntax for custom rules #47

Merged
merged 15 commits into from
Jan 23, 2024
Merged

Conversation

deemp
Copy link
Member

@deemp deemp commented Jan 16, 2024

  • Use a single syntax for Phi and Meta Phi
  • Update and run tests for user-defined rules
  • Add CLI
  • Update README

PR-Codex overview

Focus of this PR:

This PR focuses on making changes to the eo-phi-normalizer codebase, including deleting unnecessary files, adding new dependencies, and making modifications to existing files.

Detailed summary:

  • Deleted several files related to the old syntax and rules in the eo-phi-normalizer/grammar and eo-phi-normalizer/src/Language/EO/Phi/Rules/Syntax directories.
  • Added the optparse-generic dependency to the eo-phi-normalizer/package.yaml file.
  • Made changes to the eo-phi-normalizer/src/Language/EO/Phi/Normalize.hs file, including adding a new pattern match and modifying existing code.
  • Added new tests to the eo-phi-normalizer/test/eo/phi/rules/yegor.yaml file.
  • Made changes to the eo-phi-normalizer/test/Test/EO/Phi.hs file, including renaming a function and modifying existing code.
  • Added new code to the eo-phi-normalizer/test/Test/EO/Yaml.hs file.
  • Made changes to the eo-phi-normalizer/eo-phi-normalizer.cabal file, including modifying dependencies and adding new modules.
  • Made changes to the eo-phi-normalizer/Setup.hs file, including modifying the postConf function.
  • Added new code to the eo-phi-normalizer/test/Language/EO/YamlSpec.hs file.
  • Made changes to the eo-phi-normalizer/src/Language/EO/Phi/Syntax/Abs.hs file, including adding new data types and modifying existing code.
  • Removed the IsString instance from the eo-phi-normalizer/src/Language/EO/Phi/Syntax.hs file.
  • Added new code to the eo-phi-normalizer/test/Language/EO/PhiSpec.hs file.
  • Made changes to the eo-phi-normalizer/grammar/EO/Phi/Syntax.cf file, including adding a new token definition.
  • Made changes to the eo-phi-normalizer/src/Language/EO/Phi/Syntax/Par.y file

The following files were skipped due to too many changes: eo-phi-normalizer/src/Language/EO/Phi/Syntax/Doc.txt, eo-phi-normalizer/src/Language/EO/Phi/Rules/Common.hs, eo-phi-normalizer/app/Main.hs, eo-phi-normalizer/src/Language/EO/Phi/Syntax/Print.hs, eo-phi-normalizer/src/Language/EO/Phi/Rules/Yaml.hs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@deemp deemp requested a review from fizruk January 16, 2024 16:25
@deemp deemp changed the title Custom rules single syntax Use a single syntax for custom rules Jan 16, 2024
@@ -0,0 +1,20 @@
{-# LANGUAGE BlockArguments #-}
{-# LANGUAGE OverloadedRecordDot #-}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

@fizruk fizruk force-pushed the custom-rules-single-syntax branch from 46fe8fe to 2a7f2f1 Compare January 18, 2024 09:10
Co-authored-by: Abdelrahman Aly Abounegm <[email protected]>
@deemp deemp requested a review from fizruk January 18, 2024 11:38
@fizruk fizruk merged commit 1481558 into custom-rules Jan 23, 2024
@fizruk fizruk deleted the custom-rules-single-syntax branch January 23, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants