Refactor CLI and docs #153
Conversation
deemp
changed the title
| , single :: Bool | ||
| , json :: Bool | ||
| , inputFile :: Maybe FilePath |
There was a problem hiding this comment.
Why did you make it a named parameter instead of positional?
There was a problem hiding this comment.
I want to support reading a program:
- from a file:
--input-file program.phi - from an option:
--program "{ ⟦ ⟧ }" - from stdin:
--input-file -
So, I read from stdin only in the case 3.
There was a problem hiding this comment.
I don't agree with these. I think what we already had is more idiomatic and we already supported all three cases:
normalizer transform program.phiecho "{ ⟦ ⟧ }" | normalizer transformnormalizer transform
This is what I think is the approach followed by most programs I used, and what we already supported
eo-phi-normalizer/app/Main.hs
Outdated
| pprefs :: ParserPrefs | ||
| pprefs = prefs (showHelpOnEmpty <> showHelpOnError) | ||
|
|
||
| type Context = (?parserContext :: Optparse.Context) |
There was a problem hiding this comment.
I'm not familiar with many extensions, what does this syntax mean?
There was a problem hiding this comment.
It's ImplicitParams.
I use this extension instead of the ReaderT pattern.
eo-phi-normalizer/app/Main.hs
Outdated
| StructuredJSON | ||
| { input = printTree program' | ||
| , output = (printAsProgramOrAsObject <$>) <$> results | ||
| } | ||
| else do |
There was a problem hiding this comment.
Too much nesting of ifs leads to higher cognitive load when reading the code. Consider refactoring somehow
There was a problem hiding this comment.
Didn't think 1 nested if is too much.
| - `Dataless formation` - not primitive and does not have attributes bound to primitive formations. | ||
| - `⟦ d ↦ ⟦ φ ↦ ξ.ρ.c, ν ↦ ⟦ Δ ⤍ 00- ⟧ ⟧, c ↦ ∅ ⟧` |
There was a problem hiding this comment.
So just to clarify, we mean it does not have immediate attributes bound to primitive formations, but it's ok if its descendants do?
So the formation bound to d would be neither primitive nor dataless, right?
There was a problem hiding this comment.
Would be great if you can add this clarification
There was a problem hiding this comment.
A formation doesn't have non-immediate attributes, does it?
…-metrics-for-a-given-phi-expression
fizruk
deleted the
147-add-a-command-to-print-metrics-for-a-given-phi-expression
branch
CLI
defaultMainuntil we want to use pre-defined rulesDocs
.mdfilesPR-Codex overview
This PR updates the
normalizerexecutable in the Haskell project. It adds new commands, modifies dependencies, and enhances documentation.Detailed summary
normalizerexecutable.optparse-applicativeandaeson-pretty.